opentracing: Add flamegraph analysis to opentracing#14
opentracing: Add flamegraph analysis to opentracing#14farajidaneshgar wants to merge 1 commit intoeclipse-tracecompass-incubator:masterfrom
Conversation
*The AbstractCalledFunction is updated to maintain a list of children Intervals. Because in Async. Executions the overlapped time of children is calculated twice for self time calculation. So we need to maintain a list of time Intervals of children to compute the intersection of them for Self Time Calculations. Signed-off-by: Fariba Daneshgar <[email protected]>
farajidaneshgar
force-pushed
the
opernTracing
branch
from
58e6523 to
3f0cf28
Compare
arfio
left a comment
arfio
left a comment
There was a problem hiding this comment.
This patch adds some interesting features specific to opentracing but it should be changed to use the trace compass core callstack and not the incubator callstack which was recently deprecated.
| Objects.equals(getSymbol(), other.getSymbol())); | ||
| } | ||
|
|
||
| private long getChildIntersection(TmfTimeRange chlInt) { |
There was a problem hiding this comment.
This change should be removed as it does not seem to be used anywhere and changes deprecated classes ?
| org.eclipse.tracecompass.common.core, | ||
| org.eclipse.tracecompass.tmf.core, | ||
| org.eclipse.tracecompass.segmentstore.core;bundle-version="3.1.0", | ||
| org.eclipse.tracecompass.incubator.callstack.core;bundle-version="0.1.4", |
There was a problem hiding this comment.
Dependencies on org.eclipse.tracecompass.incubator.callstack.core and org.eclipse.tracecompass.incubator.analysis.core should be removed as these projects are mainly deprecated. Other dependencies should not include the bundle-version.
| class="org.eclipse.tracecompass.incubator.internal.opentracing.core.trace.OpenTracingExperiment"> | ||
| </tracetype> | ||
| </module> | ||
| <module |
There was a problem hiding this comment.
The indentation and the icon should be corrected.
| * @author Fateme Faraji Daneshgar | ||
| * | ||
| */ | ||
| public class AsincCallStackStateProvider extends AbstractTmfStateProvider { |
There was a problem hiding this comment.
AsincCallStackStateProvider -> AsyncCallStackStateProvider
| @@ -0,0 +1 @@ | |||
| package org.eclipse.tracecompass.incubator.opentracing.core.analysis.callstack; No newline at end of file | |||
There was a problem hiding this comment.
This package should be internal and if used elsewhere should add an exception in the manifest file. This file also misses the copyright header.
| @@ -0,0 +1,117 @@ | |||
| package org.eclipse.tracecompass.incubator.opentracing.core.analysis.callstack; | |||
| @@ -0,0 +1,181 @@ | |||
| package org.eclipse.tracecompass.incubator.opentracing.core.analysis.callstack; | |||
| @@ -0,0 +1,178 @@ | |||
| package org.eclipse.tracecompass.incubator.opentracing.core.analysis.callstack; | |||
| @@ -0,0 +1,33 @@ | |||
| package org.eclipse.tracecompass.incubator.opentracing.core.analysis.callstack; | |||
| @@ -0,0 +1,209 @@ | |||
| package org.eclipse.tracecompass.incubator.opentracing.core.analysis.callstack; | |||
2 participants
*The AbstractCalledFunction is updated to maintain a list of children Intervals. Because in Async. Executions the overlapped time of children is calculated twice for self time calculation. So we need to maintain a list of time Intervals of children to compute the intersection of them for Self Time Calculations.
Dependent on eclipse-tracecompass/org.eclipse.tracecompass#45